Create is_power_of_four_logarithm.py #9337
Conversation
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| import math | ||
|
|
||
|
|
||
| def is_power_of_four_logarithm(num: int) -> bool: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file maths/is_power_of_four_logarithm.py, please provide doctest for the function is_power_of_four_logarithm
maths/sum_bit_manipulation.py
Outdated
| @@ -0,0 +1,16 @@ | |||
| def add_numbers(a: int, b: int) -> int: | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file maths/sum_bit_manipulation.py, please provide doctest for the function add_numbers
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
Accidentally added another file to submission
algorithms-keeper
bot
removed
the
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| import math | ||
|
|
||
|
|
||
| def is_power_of_four_logarithm(num: int) -> bool: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file maths/is_power_of_four_logarithm.py, please provide doctest for the function is_power_of_four_logarithm
There was a problem hiding this comment.
this issue already created by me take a look - #9331 @DevAgrawal04
There was a problem hiding this comment.
kindly remove this pr I'm already work on this issue @DevAgrawal04
|
@crocmons Don't ask someone else to delete their PR just because you're working on an issue. We don't assign issues in this repo, didn't you read the contributing guidelines? If you wanted to contribute the algorithm yourself, then just open a PR and don't open an issue for it. |
@tianyizheng02 ok, Thank you for your message and clarification regarding the contribution guidelines. I appreciate your guidance. I have already submitted the pull request for the problem I am working on, following the established process. Please feel free to review it at your convenience. Once again, thank you for your time and patience. |
Fixes #9331
Describe your change:
The file defines a Python function is_power_of_four_logarithm that checks whether a given positive integer is a power of 4 using logarithms.
Checklist: